Change consent message #238
Conversation
🦋 Changeset detectedLatest commit: 2e21a5b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -13,7 +13,7 @@ export const createConsentMessage = ( | |||
| "XMTP : Grant inbox consent to sender\n" + | |||
| "\n" + | |||
| `Current Time: ${new Date(timestampMs).toUTCString()}\n` + | |||
| `From Address: ${peerAddress}\n` + | |||
| `Sender Address: ${peerAddress}\n` + | |||
There was a problem hiding this comment.
This will need to be changed in:
iOS: https://github.com/xmtp/xmtp-ios/blob/main/Sources/XMTPiOS/Messages/Signature.swift#L77
Android: https://github.com/xmtp/xmtp-android/blob/main/library/src/main/java/org/xmtp/android/library/messages/Signature.kt#L56
After those there needs to be a React Native update to include those changes and update the tests to include that change
There was a problem hiding this comment.
Ah, bummer -- thanks for the heads-up. IMO that's currently not worth the effort for this change so I'm going to delete this PR.
Update verbiage for clarity.